Implement errors.PrettyPrinter for decoding errors #518
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 79.09% 78.91% -0.19%
==========================================
Files 17 17
Lines 6110 6124 +14
==========================================
Hits 4833 4833
- Misses 965 979 +14
Partials 312 312 |
|
I've supported this feature with #535 . Thank you for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to fix #517 by implementing
errors.PrettyPrinterinterface for decoding errors.Looking at the source code, the
errstruct fields seems to always be*yaml.syntaxError, however it doesn't feel quite right to check for underlying errors' implementation ofPrettyPrinterand falling back to printing the error message. Perhaps putting themsgand thetokeninto the struct explicitly would be better.